Skip to content

Conversation

@giordano
Copy link
Member

@giordano giordano commented Nov 5, 2025

CC @matt-graham for your information.

@giordano giordano marked this pull request as draft November 5, 2025 16:09
@giordano
Copy link
Member Author

giordano commented Nov 5, 2025

Ooof, I thought this would have been simpler 😞

@giordano giordano force-pushed the mg/rm-ordinarydiffeq branch from 414aa55 to 6ee5af7 Compare November 5, 2025 16:52
@giordano giordano marked this pull request as ready for review November 6, 2025 13:22
@giordano giordano force-pushed the mg/rm-ordinarydiffeq branch from 6ee5af7 to b2acbbe Compare November 6, 2025 13:23
@giordano giordano changed the title Remove OrdinaryDiffEq from test environment, use smaller components Replace OrdinaryDiffEq with OrdinaryDiffEqTsit5 Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (523f3e5) to head (b2acbbe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files           9        9           
  Lines         654      654           
=======================================
  Hits          618      618           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member Author

giordano commented Nov 6, 2025

This is now working 🥳

@giordano giordano merged commit edf0d32 into main Nov 6, 2025
14 checks passed
@giordano giordano deleted the mg/rm-ordinarydiffeq branch November 6, 2025 13:39
Comment on lines +8 to +9
# `ForwardDiff` is only needed to trigger loading a pkgextension.
import ForwardDiff as _
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this was necessary because of SciML/OrdinaryDiffEq.jl#2900. This workaround can be removed in the future when that issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants